Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change $border to $grey-lighter in mixins. Fixes #1862 #1999

Merged
merged 1 commit into from
Jul 18, 2018
Merged

Change $border to $grey-lighter in mixins. Fixes #1862 #1999

merged 1 commit into from
Jul 18, 2018

Conversation

Log1x
Copy link
Contributor

@Log1x Log1x commented Jul 18, 2018

This is a bugfix for #1862.

Proposed solution

Change $border to $grey-lighter to allow the ability to @import mixins.sass without having to import derived-variables.sass

Tradeoffs

N/A

Testing Done

Built my project using this fork with a scenario similar to #1862 with a standalone @import of mixins.sass and am now able to build successfully.

@jgthms jgthms merged commit d4b92c0 into jgthms:master Jul 18, 2018
@Log1x Log1x deleted the patch-1 branch July 18, 2018 12:47
@snyk-bot snyk-bot mentioned this pull request Aug 13, 2019
Open
@snyk-bot snyk-bot mentioned this pull request Feb 20, 2020
Merged
@snyk-bot snyk-bot mentioned this pull request Apr 5, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 15, 2020
Open
@snyk-bot snyk-bot mentioned this pull request Apr 22, 2020
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Log1x @jgthms